HeadingPitchRoll.fromQuaternion clamps pitch asin #7654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When evaluating a
QuaternionSpline
, it may sometimes happen, that thepitch
value for looking straight down (-90°) is in fact larger then 1 by a rounding error of ~10^12. When usingHeadingPitchRoll.fromQuaternion
, this results in the.pitch
value beingNaN
.Fix
Instead of using
Math.asin
to determine the pitch, useCesiumMath.asinClamped
.