Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ellipsoid bug in GroundPolylineGeometry.unpack #7566

Merged
merged 1 commit into from
Feb 12, 2019
Merged

fix ellipsoid bug in GroundPolylineGeometry.unpack #7566

merged 1 commit into from
Feb 12, 2019

Conversation

likangning93
Copy link
Contributor

@likangning93 likangning93 commented Feb 12, 2019 •
edited
Loading

Fixes #7552.

See #7554 for additional discussion.

@cesium-concierge
Copy link

Thanks for the pull request @likangning93!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@likangning93
Copy link
Contributor Author

@hpinkos do you want to take a look?

Not absolving myself of responsibility for this weirdness, but I'm going to point fingers at @bagnell for letting the bug slip by in #6615 😛

@hpinkos
Copy link
Contributor

hpinkos commented Feb 12, 2019

👍 looks good, thanks @likangning93 !

@hpinkos hpinkos merged commit 48024a2 into master Feb 12, 2019
@hpinkos hpinkos deleted the fixGroundPolylineSmolEllipsoid branch February 12, 2019 18:19
@hpinkos hpinkos mentioned this pull request Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@likangning93 @cesium-concierge @hpinkos