Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove previously depreacted properties for 1.54 #7531

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Remove previously depreacted properties for 1.54 #7531

merged 2 commits into from
Feb 1, 2019

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Feb 1, 2019

Fixes #7394

Removes deprecated ModelAnimation.speedup and ModelAnimationCollection.speedup.

@ggetz ggetz requested a review from hpinkos February 1, 2019 15:08
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 1, 2019

Looks good! I'll merge as soon as CI passes

@hpinkos
Copy link
Contributor

hpinkos commented Feb 1, 2019

This is just failing because this branch isn't up to date with the fixes to the CWT tests. Merging. Thanks @ggetz!

@hpinkos hpinkos merged commit 00cdeef into master Feb 1, 2019
@hpinkos hpinkos deleted the remove-in-1.54 branch February 1, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpinkos hpinkos Awaiting requested review from hpinkos

Assignees
No one assigned
Labels
priority - next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggetz @cesium-concierge @hpinkos