Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IE crash from IBL. #7527

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Fix IE crash from IBL. #7527

merged 3 commits into from
Jan 30, 2019

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jan 30, 2019

Fixes #7485.

@cesium-concierge
Copy link

cesium-concierge commented Jan 30, 2019 •
edited by lilleyse
Loading

Thanks for the pull request @bagnell!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Confirmed this fixes the IE crash and still operates normally in Chrome. CI test failures are unrelated to this PR.

@lilleyse lilleyse merged commit 18e0b9d into master Jan 30, 2019
@lilleyse lilleyse deleted the ie-ibl-crash branch January 30, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bagnell @cesium-concierge @lilleyse