-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polylines on 3D Tiles Sandcastle Example #7522
Conversation
Thanks for the pull request @hpinkos!
Reviewers, don't forget to make sure that:
|
|
@pjcozzi do you have a photogrammetry tileset in mind? This is the only one we have in other Sandcastle examples. |
No, I was hoping you or @ggetz could explore. |
In the interest of getting this merged before the release, I removed the photogrammetry example. I'll open an issue to add something better for the next release. |
I dunno, this seems like the most prominent use for this polyline feature. Why not just move the polyline on the current model and write an issue to create a higher quality example that shows the full value compared to the sub-sampling example that already exists? |
@pjcozzi Something like this? If not, please give me a better idea what you're looking for. Should I draw a line over the cars to better show that it follows contours? The polylines don't look good on foliage for the same reason you didn't like it on the side of the building. |
@hpinkos Perhaps along one of the flatter vertical sides of the buildings? Or zoom in on the roof and draw lines like you would be measuring equipment there? |
@ggetz the problem with going along edges is you get lots of things like this because the walls of the building are wavy: |
@ggetz ready |
Thanks @hpinkos! Regarding
Let's write an issue to include a higher quality photogrammetry model for sandcastle examples, and mention this example could benefit from using it, along with the sub-sampling example. |
Done #7532 |
Thank @hpinkos ! |
Can you add a note to |
Yep, sorry I missed that @ggetz |
Thanks again @hpinkos ! |
Shows polylines on a BIM model:
And on Photogrammetry: