Use local videos in tests #7476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @OmarShehata!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
mramato
reviewed
Jan 10, 2019
Specs/Core/VideoSynchronizerSpec.js
Outdated
| @@ -24,17 +24,17 @@ defineSuite([ | |||
| function loadVideo() { | |||
| var element = document.createElement('video'); | |||
| var source = document.createElement('source'); | |||
| source.setAttribute('src', 'http://cesiumjs.org/videos/Sandcastle/big-buck-bunny_trailer.webm'); | |||
| source.setAttribute('src', './Data/Videos/big-buck-bunny-trailer-small.webm'); | |||
There was a problem hiding this comment.
Remove the ./, it's unneeded (plus this is a url, not a filepath)
|
Thanks @OmarShehata, just that one comment and I'll merge. |
|
@mramato all good! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to alleviate some of the issues in #7249.
Loading the videos from external URIs is one of the reasons we know the build sometimes fails. Using a local copies makes these tests a lot faster and more reliable.
The videos are scaled down versions of the original, so they're about ~20 kb each.
@mramato want to merge this?