Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unitTestPath to concierge settings #7430

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Add unitTestPath to concierge settings #7430

merged 1 commit into from
Dec 27, 2018

Conversation

OmarShehata
Copy link
Contributor

This will make concierge remind users when the unit tests haven't been updated.

@ggetz

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@OmarShehata
Copy link
Contributor Author

@hpinkos this is just a one line config change. Can you merge?

For convenience, here's the concierge config settings table.

@hpinkos
Copy link
Contributor

hpinkos commented Dec 27, 2018

👍 thanks @OmarShehata

@hpinkos hpinkos merged commit 3a1c5e3 into CesiumGS:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants