Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if cartographic is defined in clipping plane setup #7216

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Nov 1, 2018

Follow up to #7182. A tileset with a bounding sphere center exactly at (0, 0, 0) would cause a crash in the clipping planes setup.

Anyone could review this, but maybe @hpinkos?

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Nov 1, 2018

Looks good, thanks @lilleyse

@hpinkos hpinkos merged commit 7c178da into master Nov 1, 2018
@hpinkos hpinkos deleted the cartesian-zero-fix branch November 1, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants