Dramatically decrease unit test output noise when running from CLI #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When running the unit tests from the command line, do not output karma server info or browser console output. Now the only output are the tests themselves (and whether they pass/failed) 2. Add a `--verbose` flag that goes back to the old behavior that can be used for debugging specific failing tests. You need to use the verbose flag in order to see any console.log messages you add in your unit tests. 3. Travis logs are not much shorter and way less noisy. Tracking down unit test failures should now be trivial.
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
The fact that this passed all tests the first time makes me wonder if the amount of console logging we were doing previously was contributing to our random CI failure rate? Doubtful, but I'll believe anything at this point. |
|
I merged in master just to be sure, but this is ready. I'm going to do a follow up PR that gets rid of travis folding so that 1. No more clicking to see output and 2. The error will hopefully be on screen without even scrolling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the unit tests from the command line, do not output karma server info or browser console output. Now the only output are the tests themselves (and whether they pass/failed). If you suppress passed tests, only test failures are printed.
Add a
--verboseflag that goes back to the old behavior that can be used for debugging specific failing tests. You need to use the verbose flag in order to see any console.log messages you add in your unit tests.Travis logs are not much shorter and way less noisy. Tracking down unit test failures should now be trivial.
I'm also okay with keeping verbose output as the default, and adding a
--quietflag for travis, but I think most of us would rather see less noise in general. Anyone hand any thoughts?@bagnell you were just asking for this the other day I believe.