Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create function to update tileset clipping plane matrix #7177

Closed
wants to merge 1 commit into from
Closed

Create function to update tileset clipping plane matrix #7177

wants to merge 1 commit into from

Conversation

OmarShehata
Copy link
Contributor

This is just a small refactor in Cesium3DTileset.js that creates a private function for updating the clippingPlaneOffsetMatrix so that other classes that use it can ensure that this matrix is up to date before using it.

@lilleyse

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@OmarShehata
Copy link
Contributor Author

Superseded by #7182

@OmarShehata OmarShehata deleted the clipping-plane-refactor branch January 3, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants