-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyline Fixes #711
Polyline Fixes #711
Conversation
@@ -58,6 +58,13 @@ void clipLineSegmentToNearPlane( | |||
|
|||
void main() | |||
{ | |||
// cull if width is less than 1.0 | |||
if (abs(texCoordExpandWidthAndShow.z) < 1.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm fine with this. From a pure technical standpoint, should this be <= 0.0
instead of < 1.0
? Is a width between 0 and 1 never valid use case? @pjcozzi ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest not doing this check here at all. A more efficient and convenient solution is to write the show component in the vertex data as (show && width > 0.0)
. For example, see writeOriginAndShow
in BillboardCollection.js.
As for widths less than 1.0
, I would have to try it.
Other than that one question, this all looks good to me. Original problem is gone, tests pass. |
Code is OK with me. @mramato merge when you're ready. Also, we might want a test for |
Since Cozzi mentioned it, a test would be good. Assuming we have one for show, it should just be a copy/paste job. |
@mramato I added a test. This is ready. |
This has two fixes for #695.