fix bounding volumes for hemisphere-size GroundPolylineGeometry #7052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7043
Here's a primitive-based version of what was noted in the issue on the current release Sandcastle.
For comparison, in this branch's Sandcastle.
The problem was in how the bounding sphere was getting computed - the new method is simpler and should work for all cases. The bounding sphere doesn't necessarily cover the shadow volume for very short polylines in some places anymore, but those shadow volumes are extremely conservative, so in practice it shouldn't be a problem, it still covers the lines on terrain and on the ellipsoid.
Here's the spec case, roughly: