Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in StaticGroundGeometryPerMaterialBatch #7047

Merged
merged 4 commits into from
Sep 21, 2018
Merged

Fix bug in StaticGroundGeometryPerMaterialBatch #7047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be9a3b2
Fix bug in StaticGroundGeometryPerMaterialBatch where an array of ite…
impactblue573 Sep 18, 2018
fb423da
Apply length fix to StaticGeometryPerMaterialBatch
impactblue573 Sep 21, 2018
4ad883d
Apply length fix to StaticGroundPolylinePerMaterialBatch
impactblue573 Sep 21, 2018
dfe518a
Update contributors.md
impactblue573 Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
* [Matt Petry](https://github.com/MattPetry)
* [Michael Squires](https://github.com/mksquires)
* [NICTA](http://www.nicta.com.au/)
* [Chris Cooper](https://github.com/chris-cooper)
* [Kevin Ring](https://github.com/kring)
* [Keith Grochow](https://github.com/kgrochow)
* [Chloe Chen](https://github.com/chloeleichen)
Expand Down Expand Up @@ -114,7 +113,10 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
* [Roderick Green](https://github.com/roderickgreen/)
* [Hexastack](https://www.hexastack.com)
* [Mohamed Marrouchi](https://github.com/marrouchi/)

* [PropellerAero](https://www.propelleraero.com/)
* [Chris Cooper](https://github.com/chris-cooper)
* [Andrew McDowell](https://github.com/madole)
* [Tony Luk](https://github.com/impactblue573)
## [Individual CLA](Documentation/Contributors/CLAs/individual-cla-agi-v1.0.txt)
* [Victor Berchet](https://github.com/vicb)
* [Caleb Morse](https://github.com/cmorse)
Expand Down
2 changes: 1 addition & 1 deletion Source/DataSources/StaticGeometryPerMaterialBatch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ define([
}

var isUpdated = true;
for (i = 0; i < length; i++) {
for (i = 0; i < items.length; i++) {
isUpdated = items[i].update(time) && isUpdated;
}
return isUpdated;
Expand Down
2 changes: 1 addition & 1 deletion Source/DataSources/StaticGroundGeometryPerMaterialBatch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ define([
}

var isUpdated = true;
for (i = 0; i < length; i++) {
for (i = 0; i < items.length; i++) {
isUpdated = items[i].update(time) && isUpdated;
}
return isUpdated;
Expand Down
2 changes: 1 addition & 1 deletion Source/DataSources/StaticGroundPolylinePerMaterialBatch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ define([
}

var isUpdated = true;
for (i = 0; i < length; i++) {
for (i = 0; i < items.length; i++) {
isUpdated = items[i].update(time) && isUpdated;
}
return isUpdated;
Expand Down