-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clipping planes for tiles with RTC and/or no transforms #7034
Merged
lilleyse
merged 29 commits into
CesiumGS:master
from
OmarShehata:clipping-planes-matrix-fix
Sep 21, 2018
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ad7abcd
Always use root tileset's transform
9f55539
Apply RTC & bounding sphere fallback for clipping planes
9ed3695
Fixed crash if root tile wasn't loaded
bdb8799
Apply eastNorthUp to RTC center
6cb0426
Fixed RTC for b3dm
aa71e96
Traversal uses correct tileset transforms for clipping
0ec49a5
Sinplified BoundingSphere fallback check
0a07e56
No need to keep track of RTC anymore
5aee22a
Simplify clipping sandcastle example
1f1cd16
Use correct matrix for point clouds
8996da6
Fixed old tests
7d5bb57
Fix point cloud tests
b605a61
Added bounding sphere tests
0d2dd5f
Added clipping plane doc example
814c5ae
Fix 'Many Clipping Planes' example
dd3a7c6
Put back point cloud clipping plane matrix
9db4500
Style and wording edits
2dac9f4
Moved clippingPlaneOffsetMatrix to Tileset
2fadcf9
Updated tests
b251c6b
Fixed old clipping planes test
e879cca
Fix lint
5245643
Remove underscore from _clippingPlaneOffsetMatrix
65a8496
Moved clippingPlaneOffset update to tileset
3cc7aa0
No need to use setter for clippingPlaneOffsetMatrix
888e2b2
Added breaking change to CHANGES.md
f56c71c
Fix sign in doc
911a520
Reworded unionClippingRegions
a43ab57
Fix edge color for union clipping planes
79a49e0
Added terrain union example
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point cloud example might be a good use case showing when to use the clipping plane's model matrix since the clipping plane is visually off-center from the church due to the offset bounding sphere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried doing this but one issue is that, you only really need to offset the entity, so it wouldn't really need to use the clipping planes' model matrix.
The other issue is that it requires converting back and forth from Cartographic to Cartesian and it kind of makes creating a clipping plane look complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense too. And I remember now that the terrain example uses a model matrix, so one example is enough to illustrate the point.