3D Tiles style fixes #6998
Merged
3D Tiles style fixes #6998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
commented
Sep 3, 2018
| // Tile is newly selected; it is selected this frame, but was not selected last frame. | ||
| tile.lastStyleTime = 0; // Force applying the style to this tile |
There was a problem hiding this comment.
This was originally added so that expired tiles would get restyled but was responsible for the first bug. Now lastStyleTime is reset above in the // Refresh style for expired content area.
lilleyse
commented
Sep 3, 2018
| @@ -137,9 +137,8 @@ define([ | |||
| tileContent.featurePropertiesDirty = false; | |||
| tile.lastStyleTime = 0; // Force applying the style to this tile | |||
| tileset._selectedTilesToStyle.push(tile); | |||
| } else if ((tile._selectedFrame !== frameState.frameNumber - 1)) { | |||
| } else if ((tile._selectedFrame < frameState.frameNumber - 1)) { | |||
There was a problem hiding this comment.
This caused the second bug. It wasn't accounting for the fact that the pick and render pass are the same frame number.
lilleyse
force-pushed
the
style-apply-fix
branch
from
cb3f18e to
6f1331b
Compare
|
I can confirm this fixes both the issues. Thanks @lilleyse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged before the release tomorrow. It fixes bugs introduced after 1.48 so no CHANGES.md update needed.
The traversal cleanup PR #6390 had two small bugs with styling, the first one being a style always gets reapplied to a tile that was not selected the previous frame, and the second being a style always gets reapplied if the tile is selected during both the render and pick passes. These are both noticeable in the 3D Tiles Feature Picking demo.
The first bug happens when you click a building, zoom out so the tile is not selected, and zoom back in. The style gets reapplied incorrectly and the building is shown again.
The second bug happens when you click multiple buildings. The style gets applied every time a pick happens which causes all buildings to be shown.
Sample code