Fix credits for multiple viewers

[hpinkos]

Fixes #6965

We had some some class scoped credits that were causing the same credit instance to be used by the credit display in every viewer. This change clones the credit so each CreditDisplay/IonGeocoderService/IonResource/MapboxImageryProvider has it's own instance of that credit.

[cesium-concierge]

Thanks for the pull request @hpinkos!

• ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

---

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

[mramato]

Rather than adding clone and making sure we clone the module scroped credits when we add them, wouldn't it just be way cleaner to turn the module scoped credits into per instance credits? (i.e. create them in the consutrctor instead of at the module level?)

[hpinkos]

@mramato How is that different than what I'm doing? I'm creating new credit in the constructor of these classes now.

We still need module scoped something because we use these to have the same credit used for multiple classes. Or things like CreditDisplay.cesiumCredit are settable by the end user to swap out the default cesium credit. I guess since we're using all html credits now I could change the module thing to a string instead of a credit instance and call new Credit(moduleScopedCreditString) instead of Credit.clone(moduleScopedCredit), but I'm not sure that's much of a win.

[mramato]

Fair enough, we've got plenty of bigger fish to fry,