Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix viewer.zoomTo and viewer.flyTo imagery when using terrain. #6895

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Fix viewer.zoomTo and viewer.flyTo imagery when using terrain. #6895

merged 3 commits into from
Aug 8, 2018

Commits on Aug 8, 2018

  1. Fix viewer.zoomTo and viewer.flyTo imagery when using terrain. 

    1. Pull `computeFlyToLocationForRectangle` out of Geocoder and make it
a standalone private function. Add tests for it too.
2. Have Viewer call the function when zooming or flying to terrain.
    @mramato
    mramato committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    73bf8c0 View commit details
    Browse the repository at this point in the history

  2. There's no reason to sample terrain in 2D.

    @mramato
    mramato committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    ac460d4 View commit details
    Browse the repository at this point in the history

  3. Remove stray fdefineSuite

    @mramato
    mramato committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    dfd1d5d View commit details
    Browse the repository at this point in the history