Removes frameState parameter from evaluate and evaluateColor #6890
Conversation
|
Thanks for the pull request @janeyx99!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
Thanks @janeyx99, I'll take a look later! |
|
This looks really good overall. Thanks for catching some of those extra typos. A couple things: Throughout Just two areas I noticed where Add a note to |
|
@lilleyse Hey Sean, I ended up realizing
Thanks for catching the other evaluate(..frameStates...)! Is what I have for CHANGES.md okay? I'm not sure if I have to mention the deprecation period part. |
CHANGES.md
Outdated
| @@ -6,6 +6,7 @@ Change Log | |||
| ##### Breaking Changes :mega: | |||
| * Removed `ClippingPlaneCollection.clone` [#6872](https://github.com/AnalyticalGraphicsInc/cesium/pull/6872) | |||
| * Changed `Globe.pick` to return a position in ECEF coordinates regardless of the current scene mode. This will only effect you if you were working around a bug to make `Globe.pick` work in 2D and Columbus View. Use `Globe.pickWorldCoordinates` to get the position in world coordinates that correlate to the current scene mode. [#6859](https://github.com/AnalyticalGraphicsInc/cesium/pull/6859) | |||
| * Removed the unused `frameState` parameter in `evaluate`, `evaluateColor` and `applyStyle` functions [#6890](https://github.com/AnalyticalGraphicsInc/cesium/pull/6890). | |||
There was a problem hiding this comment.
No need to mention applyStyle since it is a private function.
CHANGES.md
Outdated
| @@ -6,6 +6,7 @@ Change Log | |||
| ##### Breaking Changes :mega: | |||
| * Removed `ClippingPlaneCollection.clone` [#6872](https://github.com/AnalyticalGraphicsInc/cesium/pull/6872) | |||
| * Changed `Globe.pick` to return a position in ECEF coordinates regardless of the current scene mode. This will only effect you if you were working around a bug to make `Globe.pick` work in 2D and Columbus View. Use `Globe.pickWorldCoordinates` to get the position in world coordinates that correlate to the current scene mode. [#6859](https://github.com/AnalyticalGraphicsInc/cesium/pull/6859) | |||
| * Removed the unused `frameState` parameter in `evaluate`, `evaluateColor` and `applyStyle` functions [#6890](https://github.com/AnalyticalGraphicsInc/cesium/pull/6890). | |||
There was a problem hiding this comment.
Mention the classes that the functions are removed from.
|
How's CHANGES.md now? @lilleyse |
|
I tweaked it slightly, but it looks good. |
This addresses issue #6874 and removes mentions of frameState in evaluate and evaluateColor. This helps keep frameState private.
However, frameState still appears in the documentation for ImageryLayer.js. In the constructor, some of the parameters give the user the option of taking in a function that has the signature
function(frameState, layer, x, y, level). I'm not sure if frameState is needed here, and I can't find where the source code evaluates these functions.