Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClippingPlaneCollection add/remove events #6875

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Add ClippingPlaneCollection add/remove events #6875

merged 3 commits into from
Aug 3, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Aug 2, 2018 •
edited
Loading

This adds a planeAdded and planeRemoved events to ClippingPlaneCollection

@cesium-concierge
Copy link

cesium-concierge commented Aug 2, 2018 •
edited by ggetz
Loading

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 2, 2018

@mramato can you review please?

mramato
mramato reviewed Aug 2, 2018
View reviewed changes
Source/Scene/ClippingPlaneCollection.js Outdated
* @memberof ClippingPlaneCollection.prototype
* @readonly
*/
collectionChanged : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably follow the same pattern as other objects in Scene, such as ImageryLayerCollection/ModelAnimationCollection, which have specific layerAdded/layerRemoved events. We should also pass the plane and index as part of the event.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good suggestion thanks

@hpinkos hpinkos changed the title Add ClippingPlaneCollection.collectionChanged event Add ClippingPlaneCollection add/remove events Aug 2, 2018
@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 3, 2018

@mramato this is ready

@hpinkos hpinkos closed this Aug 3, 2018
@hpinkos hpinkos reopened this Aug 3, 2018
@mramato
Copy link
Contributor

mramato commented Aug 3, 2018

Thanks.

@mramato mramato merged commit 49db47f into master Aug 3, 2018
@mramato mramato deleted the clipping-planes-changed branch August 3, 2018 14:32
@mramato
Copy link
Contributor

mramato commented Aug 3, 2018

@hpinkos I was quick on the draw and just realized CHANGES needs to be updated to reflect the review changes and also mention the braking change.

@mramato
Copy link
Contributor

mramato commented Aug 3, 2018

(Please just do it in master)

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 3, 2018

Breaking change? There is no breaking change in this PR

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 3, 2018

Update CHANGES bb856df

@mramato
Copy link
Contributor

mramato commented Aug 3, 2018

Breaking change? There is no breaking change in this PR

Yeah, I got it confused with your clone PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mramato mramato mramato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpinkos @cesium-concierge @mramato