Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #6779 #6866

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Revert #6779 #6866

merged 2 commits into from
Jul 31, 2018

Conversation

lilleyse
Copy link
Contributor

Fixes #6814

#6779 fixed a bug that caused tilesets to show through the globe but introduced a different bug that caused pickPosition to fail when picking the globe when globe.depthTestAgainstTerrain is false. For the sake of not introducing a different bug we decided to revert #6779 for now.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse
Copy link
Contributor Author

Need to revert CHANGES.md, one second.

@lilleyse
Copy link
Contributor Author

Ready

@hpinkos
Copy link
Contributor

hpinkos commented Jul 31, 2018

@lilleyse can you open up an issue for what #6779 was fixing?

@lilleyse
Copy link
Contributor Author

Here: #6867

@hpinkos
Copy link
Contributor

hpinkos commented Jul 31, 2018

Thanks @lilleyse!

@hpinkos hpinkos merged commit f50e0c3 into master Jul 31, 2018
@hpinkos hpinkos deleted the revert-6779 branch July 31, 2018 21:14
@hpinkos hpinkos mentioned this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pickPosition broken when point cloud tileset added to scene
3 participants