Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tangent/bitangent when stRotation is applied #6788

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 10, 2018

Polygon and ellipse were both computing tangent and bitangent incorrectly when the stRotation option was used. This is because stRotation is being applied clockwise and the rotation to the tangent/bitangent was being applied counter-clockwise.

Before:
image

After:
image

Ellipse sample code

Polygon sample code

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@bagnell
Copy link
Contributor

bagnell commented Jul 11, 2018

Good catch.

@bagnell bagnell merged commit 2fa8660 into master Jul 11, 2018
@bagnell bagnell deleted the fix-polygon-tangents branch July 11, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants