fixes for some test failures on IE and Firefox #6766
Conversation
|
@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
| @@ -33,11 +33,11 @@ defineSuite([ | |||
| var values = attribute.values; | |||
| var componentsPerAttribute = attribute.componentsPerAttribute; | |||
| var vertexCount = values.length / componentsPerAttribute; | |||
| var firstVertex = values.slice(0, componentsPerAttribute); | |||
| var firstVertex = Array.prototype.slice.call(values, 0, componentsPerAttribute); | |||
There was a problem hiding this comment.
Specs/Core/RectangleGeometrySpec.js
Outdated
| expect(CesiumMath.toDegrees(r.south)).toEqual(-1.414213562373095); | ||
| expect(CesiumMath.toDegrees(r.east)).toEqual(1.414213562373095); | ||
| expect(CesiumMath.toDegrees(r.west)).toEqual(-1.4142135623730951); | ||
| expect(CesiumMath.toDegrees(r.north)).toEqualEpsilon(1.414213562373095, CesiumMath.EPSILON7); |
There was a problem hiding this comment.
Isn't epsilon 7 a little low here? Is that really the best we can do? Same for circle geometry.
|
Thanks @likangning93 Merging after testing locally to speed up the release process. |
Fixes for some low-hanging (and admittedly low-impact) test failures for IE and Firefox.