Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamp to far plane for polyline on terrain volumes #6751

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

likangning93
Copy link
Contributor

(Small) part of #6735.

I was only able to reproduce this part of the issue with log depth disabled and at some pretty specific views.

@cesium-concierge
Copy link

Signed CLA is on file.

@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@likangning93
Copy link
Contributor Author

Thanks bot! No CHANGES.md update, fix is for a feature that's new this release.

@bagnell
Copy link
Contributor

bagnell commented Jun 28, 2018

Not just an issue in #6735, but with log depth disabled on PC as well.

@bagnell
Copy link
Contributor

bagnell commented Jun 28, 2018

👍

@bagnell bagnell merged commit d3cc317 into master Jun 28, 2018
@bagnell bagnell deleted the clampDepthFarPlane branch June 28, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants