Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #6612: Missing tiles in VR mode (regression w.r.t. Cesium 1.44) #6663

Closed
wants to merge 4 commits into from

Conversation

glathoud
Copy link
Contributor

@glathoud glathoud commented Jun 6, 2018

Two small commits to better support VR, in particular to avoid having missing tiles. See also #6612

@cesium-concierge
Copy link

Please sign the CLA before we review this PR.

Welcome to the Cesium community @glathoud!

Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 6, 2018

Thanks again @glathoud, we also received your CLA.

@hpinkos
Copy link
Contributor

hpinkos commented Jun 6, 2018

Thanks @glathoud! @bagnell could you review?

@bagnell
Copy link
Contributor

bagnell commented Jul 12, 2018

Thanks for looking into this @glathoud. The problem was deeper in the engine where we change the frustum aspect ratios for the two eyes. Closing this in favor of #6798.

@bagnell bagnell closed this Jul 12, 2018
@glathoud
Copy link
Contributor Author

@bagnell Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants