Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize cross product result for up vector to fix #6640 #6641

Merged
merged 5 commits into from
Oct 23, 2018

Conversation

xtassin
Copy link
Contributor

@xtassin xtassin commented May 31, 2018

At minima, normalizing the up vector obtained from cross product resolves issue #6640

Other cross product results in this function could also be normalized but only the up vector was causing the effect noticed in the mentioned issue.

This is my first pull request to Cesium, let me know if anything wrong.

At minima, normalizing the up vector obtained from cross product resolves issue CesiumGS#6640
Other cross product results in this function could also be normalized but only the up vector was causing the effect noticed in the mentioned issue.
@cesium-concierge
Copy link

Please sign the CLA before we review this PR.

Welcome to the Cesium community @xtassin!

Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi
Copy link
Contributor

pjcozzi commented May 31, 2018

Thanks @xtassin, we received your CLA, someone will review soon!

@ggetz ggetz mentioned this pull request Jun 1, 2018
@xtassin xtassin closed this Jun 1, 2018
@xtassin xtassin reopened this Jun 1, 2018
@hpinkos
Copy link
Contributor

hpinkos commented Jun 4, 2018

Thanks @xtassin! I think we do also want to normalize the right vector.

And can you update CONTRIBUTORS.md in this pull request? You can edit the file right on GitHub here: https://github.com/xtassin/cesium/blob/patch-1/CONTRIBUTORS.md

@hpinkos
Copy link
Contributor

hpinkos commented Jul 30, 2018

@xtassin do you have time to finish up this pull request? We also want to normalize the right vector, then you should add yoursefl to the list in CONTRIBUTORS.md. Thanks!

@hpinkos
Copy link
Contributor

hpinkos commented Oct 23, 2018

Sorry for the delay on this @xtassin, I didn't realize you had committed those changes. Thanks for the contribution!

@hpinkos hpinkos merged commit 3c69b57 into CesiumGS:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants