Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix classification type not getting propagated properly for dynamic entities on terrain #6608

Merged
merged 4 commits into from
May 22, 2018
Merged

fix classification type not getting propagated properly for dynamic entities on terrain #6608

merged 4 commits into from
May 22, 2018

Conversation

likangning93
Copy link
Contributor

Fixes #6606

@cesium-concierge
Copy link

Signed CLA is on file.

@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented May 22, 2018

Can we easily add a unit test here?

@hpinkos please review/merge when happy. Thanks to both of you!

@hpinkos
Copy link
Contributor

hpinkos commented May 22, 2018

@likangning93 yeah, can you add a test to createGeometryUpdaterGroundGeometrySpecs? It should be similar to the dynamic updater on terrain test, just check the value is being set on the primitive added to groundPrimitives

@likangning93
Copy link
Contributor Author

@hpinkos ready!

hpinkos
hpinkos reviewed May 22, 2018
View reviewed changes
Specs/createGeometryUpdaterGroundGeometrySpecs.js
@@ -154,6 +156,24 @@ define([
dynamicUpdater.destroy();
updater.destroy();
});

it('dynamic updater on terrain propagates classification type', function() {
var entity = createDynamicEntity();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting classificationType in each of the XXXGeometryUpdaterSpec files, do entity[geometryPropertyName].classificationType = ClassificationType.BOTH in this file

@likangning93
Copy link
Contributor Author

@hpinkos updated

@hpinkos
Copy link
Contributor

hpinkos commented May 22, 2018

Perfect, thanks @likangning93!

@hpinkos hpinkos merged commit b6e9273 into CesiumGS:master May 22, 2018
@hpinkos hpinkos deleted the fixDynamicGeometryOnTerrain branch May 22, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpinkos hpinkos hpinkos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@likangning93 @cesium-concierge @mramato @hpinkos