Draco fix for #6523 #6525
Draco fix for #6523 #6525
Conversation
|
@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Source/Scene/ModelUtility.js
Outdated
| var index = string.indexOf(find); | ||
| return string.replace(new RegExp(find, 'g'), function(match, offset) { | ||
| // Limit search to strings that are not a subset of other tokens. | ||
| find += '(?![a-zA-Z_$])'; |
There was a problem hiding this comment.
Yes, also realized I missed 0-9.
There was a problem hiding this comment.
I guess in that case, could \w be used instead?
Source/Scene/ModelUtility.js
Outdated
| find += '(?![a-zA-Z_$])'; | ||
| find = new RegExp(find, 'g'); | ||
|
|
||
| var index = regexIndexOf(string, find, 0); |
There was a problem hiding this comment.
Could this line just be replaced with var index = string.search(find); and regexIndexOf be removed?
|
@lilleyse updated |
|
Thanks! |
Fixes #6523
replaceAllButFirstInStringwas replacing the variable name everywhere, even in subsets of other variables, (ex.a_positionwas replaced in botha_positionanda_position_1).