-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check projection instead of tiling scheme #6524
Conversation
This allows custom tiling scheme classes by actually checking the projection in the tiling scheme rather than the tiling scheme class itself.
@wallw-bits, thanks for the pull request! Maintainers, we have a signed CLA from @wallw-bits, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
This should be a no-change update for Cesium itself. It only affects those attempting to use custom TilingScheme classes. Hence no update to |
Thanks @wallw-bits! If this fixes a bug when you were trying to use a custom tiling scheme, you should make a note in Who can review this? @kring do you have time to take a look? |
|
Yep I'll take a look @hpinkos. |
Looks good, thanks @wallw-bits! |
Congratulations on closing the issue! I found these Cesium forum links in the comments above: https://groups.google.com/forum/#!topic/cesium-dev/a8hNaDBnAEw If this issue affects any of these threads, please post a comment like the following:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
I think this was merged after the release was cut, which makes the Should I make another PR to fix that? |
Move update from #6524 to next release (since it was merged after the release happened).
Good catch @wallw-bits, I fixed this directly in master so you don't have to worry about it 76d64a1 |
I believe that this fixed using NASA GIBS' Geographic Tiling Scheme (https://github.com/nasa-gibs/gibs-web-examples/blob/master/lib/gibs/gibs.js) which previously produced a blurry image at lower zoom levels. Pulling master into my fork this morning fixed this issue. I'm now able to use a custom GibsGeographicTilingScheme.js (based on gibs.js link above) to display Blue Marble and other NASA tiles without issue, whereas before I had to use their reprojected tiles for them to display correctly in Cesium. |
This allows custom tiling scheme classes by actually checking the projection in the tiling scheme rather than the tiling scheme class itself.
The use case was outlined in the forum here. However, I went ahead and changed all the places that similar checks were being done, rather than just the one I mentioned in the forum.