Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Resource.delete to send data #6468

Merged
merged 2 commits into from
Apr 20, 2018
Merged

Allow Resource.delete to send data #6468

merged 2 commits into from
Apr 20, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Apr 19, 2018

@cesium-concierge
Copy link

Signed CLA is on file.

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@@ -1446,7 +1446,8 @@ define([
return resource.delete({
// Make copy of just the needed fields because headers can be passed to both the constructor and to fetch
responseType: options.responseType,
overrideMimeType: options.overrideMimeType
overrideMimeType: options.overrideMimeType,
data: options.data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add options.data to the doc.

@hpinkos
Copy link
Contributor Author

hpinkos commented Apr 20, 2018

@tfili ready

@tfili tfili merged commit 4604a49 into master Apr 20, 2018
@tfili tfili deleted the resource-delete-data branch April 20, 2018 15:19
hanbollar pushed a commit to hanbollar/cesium that referenced this pull request Apr 20, 2018
…delete-data

Allow Resource.delete to send data
hanbollar pushed a commit to hanbollar/cesium that referenced this pull request Apr 20, 2018
…delete-data

Allow Resource.delete to send data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants