Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Pelias geocoder #6453

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Add support for the Pelias geocoder #6453

merged 1 commit into from
Apr 17, 2018

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Apr 17, 2018

Pelias is an open source geocoder originally built by Mapzen. This adds PeliasGeocoderService for use with the Geocoder widget.

Because Pelias (and some other geocoders) differentiate between an autocomplete request and a search request, I added an optional parameter to GeocoderService.geocode to provide that information. The widget will use auto-complete as you are typing and search once you hit enter or select a value from the dropdown.

To test this, you'll need either a local Pelias server or a geocode.earth account. I don't know of any other Pelias servers "in the wild".

@hpinkos I'll send you instructions for testing this using our servers.

CC @orangejulius (Just wanted to let you know this was going in).

[Pelias](https://pelias.io/) is an open source geocoder originally built
by Mapzen. This adds `PeliasGeocoderService` for use with the Geocoder
widget.

Because Pelias (and some other geocoders) differentiate between an
`autocomplete` request and a `search` request, I added an optional
parameter to `GeocoderService.geocode` to provide that information. The
widget will us auto-complete as you are typing and `search` once you hit
enter or select a value from the dropdown.
@mramato mramato requested a review from hpinkos April 17, 2018 01:12
@cesium-concierge
Copy link

Signed CLA is on file.

@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@orangejulius
Copy link

Nice :)

@hpinkos
Copy link
Contributor

hpinkos commented Apr 17, 2018

Flawless

@hpinkos hpinkos merged commit c32d946 into master Apr 17, 2018
@hpinkos hpinkos deleted the pelias branch April 17, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants