Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classification primitives become ready when show is false #6428

Merged
merged 3 commits into from
Apr 10, 2018

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Apr 5, 2018

Ground and classification primitives will become ready when show is false. For #6413.

CC @mramato @hpinkos The tests fail in master from timing out. Is there a better test?

@cesium-concierge
Copy link

Signed CLA is on file.

@bagnell, thanks for the pull request! Maintainers, we have a signed CLA from @bagnell, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Apr 5, 2018

This looks good to me! And this should allow @roderickgreen to finish his flickering polygons pull request.

@mramato did you want to take a quick look at this?

@mramato
Copy link
Contributor

mramato commented Apr 10, 2018

This is fine with me, I merged in master so as soon as this is green someone can hit merge.

@mramato
Copy link
Contributor

mramato commented Apr 10, 2018

Thanks @bagnell

@mramato mramato merged commit 5b2890f into master Apr 10, 2018
@mramato mramato deleted the primitive-ready branch April 10, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants