Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default value when entity geometry attributes are undefined #6377

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Mar 27, 2018

Fixes #6369

The crash was happening because color was undefined for half the interval. This change uses Property.getValueOrUndefined to make sure we're not trying to set attributes to an undefined value.

Also added specs because we're missing a ton of unit test coverage for entity geometry batches

@cesium-concierge
Copy link

Signed CLA is on file.

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Mar 27, 2018

Looks like you have some test failures (possibly epsilon related?)

@mramato
Copy link
Contributor

mramato commented Mar 27, 2018

Otherwise this looks good to me, bump when ready and I'll do a final smokescreen with #6369 data and merge.

@hpinkos hpinkos force-pushed the fix-geometry-entities branch from 1a7ce84 to c932599 Compare March 27, 2018 19:15
@hpinkos
Copy link
Contributor Author

hpinkos commented Mar 27, 2018

@mramato ready

@mramato
Copy link
Contributor

mramato commented Mar 27, 2018

Thanks again.

@mramato mramato merged commit 80ef62b into master Mar 27, 2018
@mramato mramato deleted the fix-geometry-entities branch March 27, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants