-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add width and height parameters to Scene.drillPick #6363
Conversation
Welcome to the Cesium community @sir-chaos! Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Thanks for the pull request @sir-chaos! When you have a moment, can you send over a CLA? We need that in order to review and merge your changes. Instructions are in the cesium-concierge post above. Also, we'll probably want some unit tests before merging this. Thanks! |
@hpinkos sure, just did it. Hope the tests will pass :) |
Thanks again @sir-chaos, we received your CLA, sorry for the slow response. |
Hi @sir-chaos, did you add unit tests? If you did you may have forgotten to push them up, I don't see it in this pull request |
Hi @hpinkos, probably I misunderstood your last comment, so no tests added yet, but I can try and do that. |
Thanks again for the pull request! Looks like this pull request hasn't been updated in 30 days since I last commented. To keep things tidy should this be closed? Perhaps keep the branch and submit an issue?I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Hi, what is the status of this PR @sir-chaos ? |
Thanks for the PR @sir-chaos! @chris-cooper went ahead and finished up these changes in #6922. These changes will be included in Cesium 1.49 available on September 3rd. |
Glad to hear that. |
On #6361