Fix default value of alphaCutoff. #6346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gltf-pipeline PR is CesiumGS/gltf-pipeline#355. |
|
The code looks good. Does this need an update to CHANGES.md? |
|
Also if easy enough to create, maybe a test too? |
|
The tests here aren't very detailed, just checks to see if rendering completely fails when one of the alpha modes is toggled on. At some point we should switch over to the Asset Generator and do comparison against reference images, but I think that's a large project. CHANGES updated. Odd that Concierge didn't chime in about that. |
|
Ok sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glTF spec defines a default value of
0.5foralphaCutoff.See: KhronosGroup/glTF-Sample-Models#156