Draco Fixes #6341
Draco Fixes #6341
Conversation
|
@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Source/Scene/DracoLoader.js
Outdated
| loadResources.primitivesToDecode.dequeue(); | ||
| return promise.then(addDecodededBuffers(taskData, model, context)); | ||
| return promise.then(addDecodededBuffers(model, context)) |
There was a problem hiding this comment.
Can we rename addDecodededBuffers to createAddDecodedBuffersCallback or something similar, otherwise it looks like a bug in promise usage in the code.
Although why is this even a separate function? Might be more readable to just declare it inline since it's the only place it's used.
There was a problem hiding this comment.
These changes look good. Also check out my note here: #6191 (comment)
Source/Scene/Model.js
Outdated
| * </li><li> | ||
| * {@link https://github.com/KhronosGroup/glTF/blob/master/extensions/1.0/Vendor/WEB3D_quantized_attributes/README.md|WEB3D_quantized_attributes} | ||
| * </li><li> | ||
| * {@link https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_materials_pbrSpecularGlossiness/README.md|KHR_materials_pbrSpecularGlossiness} |
There was a problem hiding this comment.
Cesium doesn't support the spec-gloss extension at the moment.
|
Oh I think I missed your recent commit. One second... |
|
@lilleyse Sorry if I missed it, but do you have any thoughts regarding #6191 (comment)? |
|
@lilleyse Updated! |
|
Thanks @ggetz, the new approach looks good. |
@lilleyse
Includes updates as suggested in #6191 and fixes for concurrency found when loading tilesets