Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zoom to dynamic geometry #6281

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Fix zoom to dynamic geometry #6281

merged 2 commits into from
Feb 28, 2018

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Feb 27, 2018

Fixes #6269

Moved raising the postRender event to after the frameState.afterRender functions are all called, which means the primitives are once again being marked as ready in time for the viewer to get the boundingSpheres to zoom to.

Double checked throughout the code base, and Viewer._afterRender was the only Cesium after render function which depended on the frameState.afterRender functions being called first.

@ggetz ggetz requested a review from hpinkos February 27, 2018 18:44
@cesium-concierge
Copy link

Signed CLA is on file.

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Feb 28, 2018

Thanks @ggetz!

@hpinkos hpinkos merged commit 087bda0 into master Feb 28, 2018
@hpinkos hpinkos deleted the zoom-to-fix branch February 28, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants