-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ion Assets Sandcastle tab and new assets to BaseLayerPicker #6278
Conversation
1. Add `Sentinel-2`, `Blue Marble`, and `Earth at night` to BaseLayerPicker 2. Removed old Black Marble from the BaseLayerPicker. 3. Add new `ion Assets` tab to Sandcastle to showcase initial assets available to Cesium users. 4. Update ArcticDEM example to use ion version instead of deprecated assets.agi.com. 5. Rename PATerrain example to the more accurate `PAMAP Terrain` and have it use ion version instead of deprecated assets.agi.com. 6. Add bare bones `Blue Marble`, `Cesium World Terrain`, `Earth at Night`, `Natural Earth II`, `Sentinel-2`, and `Washington DC 2017` examples. 7. Update examples using deprecated cesiumjs.org version of Black Marble to use the newer Earth at Night ion asset. 8. Resize some overly-large gallery images.
@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
At quick glance, all sounds good. 🚀 Can someone please do a quick review of the examples? |
|
Should we link to a terms of use or a blog post about ion from the examples? |
The larger
This I'll do.
DEM implies it's a terrain example, we don't add "Imagery" to the imagery examples, so I'm not sure this makes sense. I think we'll be fine once I add additional comments.
I see no reason to do this. Our examples always do too much. The point of this example is to show how to load the layer. Disabling the base layer picker adds nothing to the example. |
I don't like that the base layer picker has no icon for the imagery examples |
You were the one that request we show nothing when an item wasn't selected, and the lack of an icon has nothing to do with the example. I stand by my comment. |
Also resnap some thumbnails.
This is ready. |
Thanks |
Sentinel-2
,Blue Marble
, andEarth at night
to BaseLayerPickerion Assets
tab to Sandcastle to showcase initial assets available to Cesium users.PATerrain
example to the more accuratePAMAP Terrain
and have it use ion version instead of deprecated assets.agi.com.Blue Marble
,Cesium World Terrain
,Earth at Night
,Natural Earth II
,Sentinel-2
, andWashington DC 2017
examples.CC @pjcozzi