Consolidate duplicate specs for geometry entities #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
hpinkos
force-pushed
the
geometry-entity-specs
branch
from
6905598 to
ae9d68f
Compare
hpinkos
force-pushed
the
geometry-entity-specs
branch
from
ae9d68f to
4ea3c6b
Compare
|
Another 3,300 lines of code gone. You're on fire this month @hpinkos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following helper functions for creating specs for each
GeometryUpdatertypecreateGeometryUpdaterSpecs- Static geometry updater specscreateDynamicGeometryUpdaterSpecs- Dynamic geometry updater specscreateGeometryUpdaterGroundGeometrySpecs- Ground primitive specs