-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust request priority for close globe tiles #6247
Conversation
@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Update CHANGES.md Do you think the heurtisc should also take into account |
This could maybe be good in some situations. It would have to be tuned pretty carefully since it might de-prioritize tiles that are not straight on but still take up a lot of pixel space. I'll add this idea to #6243. |
I think I'm going to have all the 3D Tiles PR's go into |
9dc1753
to
2c1af11
Compare
2c1af11
to
7cda13e
Compare
6dcf777
to
fa3a642
Compare
This seems to only prioritise the tile in the very center of the screen – perhaps it would be an idea to prioritise all tiles visible to the camera? Or even discard those in the queue that aren't visible? |
@kring will this be replaced by your latest work? |
Yes I'd say so. The modified function has been removed entirely in my branch. |
Fine to delete this branch. |
For #6243
Fixes #5954
If the camera is inside a globe tile's bounding rectangle, that tile will be requested with highest priority. This prevents 3D Tiles requests from possibly starving imagery/terrain requests. This is especially important for the root globe tile and other large tiles where distance is a bad metric and they should really be loaded right away.
I'm not sure if I've truly seen 3D Tiles starve imagery/terrain (#5954 is more of an edge case), but this would prevent that from happening.