Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust request priority for close globe tiles #6247

Closed
wants to merge 1 commit into from

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Feb 21, 2018

For #6243
Fixes #5954

If the camera is inside a globe tile's bounding rectangle, that tile will be requested with highest priority. This prevents 3D Tiles requests from possibly starving imagery/terrain requests. This is especially important for the root globe tile and other large tiles where distance is a bad metric and they should really be loaded right away.

I'm not sure if I've truly seen 3D Tiles starve imagery/terrain (#5954 is more of an edge case), but this would prevent that from happening.

@cesium-concierge
Copy link

Signed CLA is on file.

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 21, 2018

Update CHANGES.md

Do you think the heurtisc should also take into account dot(view-direction, tile surface normal) so that the more the viewer is looking at the tile, the more important it is?

@lilleyse lilleyse mentioned this pull request Mar 29, 2018
2 tasks
@lilleyse
Copy link
Contributor Author

Do you think the heurtisc should also take into account dot(view-direction, tile surface normal) so that the more the viewer is looking at the tile, the more important it is?

This could maybe be good in some situations. It would have to be tuned pretty carefully since it might de-prioritize tiles that are not straight on but still take up a lot of pixel space.

I'll add this idea to #6243.

@lilleyse
Copy link
Contributor Author

Update CHANGES.md

I think I'm going to have all the 3D Tiles PR's go into request-performance and write a more general entry in CHANGES.md.

@lilleyse lilleyse changed the base branch from request-queue to request-performance March 29, 2018 19:51
@lilleyse lilleyse force-pushed the request-terrain-fix branch from 9dc1753 to 2c1af11 Compare March 29, 2018 20:23
@lilleyse lilleyse force-pushed the request-terrain-fix branch from 2c1af11 to 7cda13e Compare March 29, 2018 20:24
@lilleyse lilleyse force-pushed the request-performance branch from 6dcf777 to fa3a642 Compare March 29, 2018 20:26
@puckey
Copy link
Contributor

puckey commented Apr 28, 2018

This seems to only prioritise the tile in the very center of the screen – perhaps it would be an idea to prioritise all tiles visible to the camera? Or even discard those in the queue that aren't visible?

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 4, 2018

@kring will this be replaced by your latest work?

@kring
Copy link
Member

kring commented Jul 4, 2018

@kring will this be replaced by your latest work?

Yes I'd say so. The modified function has been removed entirely in my branch.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 4, 2018

Gotcha.

@lilleyse please coordinate if there is anything worth saving/discussing with @kring and then delete this branch when ready. Thanks.

@pjcozzi pjcozzi closed this Jul 4, 2018
@lilleyse
Copy link
Contributor Author

lilleyse commented Jul 5, 2018

Fine to delete this branch.

@lilleyse lilleyse deleted the request-terrain-fix branch July 5, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants