Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cesium.Math.cbrt #6222

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Added Cesium.Math.cbrt #6222

merged 3 commits into from
Feb 15, 2018

Conversation

lilleyse
Copy link
Contributor

For https://github.com/AnalyticalGraphicsInc/cesium/pull/6220/files#r168309211

I wasn't sure how far to take the polyfill. Right now it acts like Math.cbrt in that if you pass in undefined it returns NaN.

I can add a defined check if that makes more sense.

@cesium-concierge
Copy link

Signed CLA is on file.

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Feb 15, 2018

I don't think the defined check is needed, this only gets executed on IE 11 anyway. Thanks.

@mramato mramato merged commit d0a70e7 into master Feb 15, 2018
@mramato mramato deleted the cbrt branch February 15, 2018 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants