Fix for AxisAlignedBoundingBox clone method #6183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before the fix - if result was not defined returned constructed AxisAlignedBoundingBox without copying over center value.
The issue with this is that if the user, for their own purposes, constructed a center value with an offset s.t. the minimum and maximum weren't the same distance away from the center parameter, the clone method would not consider this form of construction and just solve for the default center based on max and min values.
Additionally, since the minimum and maximum values are defined in relation to the center (ie as if the center was the origin for them) the clone's box's overall position doesnt match that of the box it's cloning.