Fixed Invalid asm.js: Invalid member of stdlib console error
#5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Recompiled crunch.js with latest emscripten toolchain, the version is the same as what we were already using. I also updated the license header to match what is in license.txt on their repository. Fixes #5847
|
@bagnell all of the tests pass, wasn't sure if there was a better way to verify that I didn't break anything. |
bagnell
approved these changes
Nov 9, 2017
|
If the tests pass, this is good. Here is one of our test models with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recompiled crunch.js with latest emscripten toolchain, the version is the same as what we were already using.
I also updated the license header to match what is in license.txt on their repository.
Fixes #5847