Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KML ground overlay distortion bug #5915

Merged
merged 4 commits into from
Oct 18, 2017
Merged

Fix KML ground overlay distortion bug #5915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63dadff
Fix rotated KML ground overlays.
juburr Oct 18, 2017
ea7e429
Add Novetta to contributors file.
juburr Oct 18, 2017
ff876b5
Add KML ground overlay fix to change log.
juburr Oct 18, 2017
c234032
Added texture rotation check to KML ground overlay rotation unit test.
juburr Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ Change Log
==========
### 1.39 - 2017-11-01
* Added support for the layer.json `parentUrl` property in `CesiumTerrainProvider` to allow for compositing of tilesets.
* Fixed a bug that caused KML ground overlays to appear distorted when rotation was applied. [#5914](https://github.com/AnalyticalGraphicsInc/cesium/issues/5914)

### 1.38 - 2017-10-02

Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
* [Jannes Bolling](https://github.com/jbo023)
* [Logilab](https://www.logilab.fr/)
* [Florent Cayré](https://github.com/fcayre/)
* [Novetta](http://www.novetta.com/)
* [Justin Burr](https://github.com/jburr-nc/)

## [Individual CLA](Documentation/Contributors/CLAs/individual-cla-agi-v1.0.txt)
* [Victor Berchet](https://github.com/vicb)
Expand Down
4 changes: 3 additions & 1 deletion Source/DataSources/KmlDataSource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1842,7 +1842,9 @@ define([

var rotation = queryNumericValue(latLonBox, 'rotation', namespaces.kml);
if (defined(rotation)) {
geometry.rotation = CesiumMath.toRadians(rotation);
var rotationRadians = CesiumMath.toRadians(rotation);
geometry.rotation = rotationRadians;
geometry.stRotation = rotationRadians;
}
}
}
Expand Down
1 change: 1 addition & 0 deletions Specs/DataSources/KmlDataSourceSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,7 @@ defineSuite([
expect(entity.polygon).toBeUndefined();
expect(entity.rectangle.coordinates.getValue()).toEqualEpsilon(Rectangle.fromDegrees(3, 1, 4, 2), CesiumMath.EPSILON14);
expect(entity.rectangle.rotation.getValue()).toEqual(Math.PI / 4);
expect(entity.rectangle.stRotation.getValue()).toEqual(Math.PI / 4);
});
});

Expand Down