Calculate HPR counter clock wise #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcozzi
reviewed
Sep 28, 2017
CHANGES.md
Outdated
| @@ -8,6 +8,8 @@ Change Log | |||
| * `Scene/OrthographicOffCenterFrustum` has been removed. Use `Core/OrthographicOffCenterFrustum`. | |||
| * `Scene/PerspectiveFrustum` has been removed. Use `Core/PerspectiveFrustum`. | |||
| * `Scene/PerspectiveOffCenterFrustum` has been removed. Use `Core/PerspectiveOffCenterFrustum`. | |||
| * Deprecated | |||
| * The default behavior of the functions `HeadingPitchRoll.fromQuaternion`, `Matrix3.fromHeadingPitchRoll`, `Quaternion.fromHeadingPitchRoll`, `Transforms.headingPitchRollToFixedFrame`, and `Transforms.headingPitchRollQuaternion` has been deprecated. An optional boolean flag can be supplied to these functions that, if true, uses the classical orientation of heading and pitch calculated counter-clockwise. The flag will be removed and the new behavior made default in 1.40.[#5666](https://github.com/AnalyticalGraphicsInc/cesium/issues/5666) | |||
There was a problem hiding this comment.
Please update this and move it to the breaking change section.
pjcozzi
reviewed
Sep 28, 2017
Source/Core/HeadingPitchRoll.js
Outdated
| @@ -40,17 +42,23 @@ define([ | |||
| throw new DeveloperError('quaternion is required'); | |||
| } | |||
| //>>includeEnd('debug'); | |||
|
|
|||
| deprecationWarning('HeadingPitchRoll.fromQuaternion', 'This function now uses a counter-clockwise orientation as per mathematical conventions. This deprecation warning will be removed in Cesium 1.40.'); | |||
There was a problem hiding this comment.
Submit an issue to remove this warning.
Also, make the warning more precise. This started in 1.38 and users just need to add the negative sign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't push to that branch directly, but additional fixes to #5809