Fix bug where yellow icon is shown when icon tag is empty #5819

CHANGES.md

@@ -15,6 +15,7 @@ Change Log
 * Fixed CZML processing of `velocityReference` within an interval. [#5738](https://github.com/AnalyticalGraphicsInc/cesium/issues/5738)
 * Zoom about mouse now maintains camera heading, pitch, and roll [#4639](https://github.com/AnalyticalGraphicsInc/cesium/pull/5603)
 * Fixed a bug in `PolylineCollection` preventing the display of more than 16K points in a single collection [#5538](https://github.com/AnalyticalGraphicsInc/cesium/pull/5782)
+* Fixed bug with placemarks in imported KML: placemarks with no specified icon would be displayed with default icon (https://github.com/AnalyticalGraphicsInc/cesium/issues/5819)
 
 ### 1.37 - 2017-09-01
 

Source/DataSources/KmlDataSource.js

@@ -1111,10 +1111,6 @@ define([
             entity.billboard = billboard;
         }
 
-        if (!defined(billboard.image)) {
-            billboard.image = dataSource._pinBuilder.fromColor(Color.YELLOW, 64);
-        }
-
         var scale = 1.0;
         if (defined(billboard.scale)) {
             scale = billboard.scale.getValue();

Specs/Data/KML/simpleNoIcon.kml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<kml xmlns="http://www.opengis.net/kml/2.2">
+<Document>
+	<Placemark>
+		<Style>
+			<IconStyle>
+			  <Icon>
+			  </Icon>
+			</IconStyle>
+		</Style>
+		<description><![CDATA[image.png <a href="./image.png">image.png</a><img src="image.png"/>]]></description>
+		<Point>
+			<coordinates>1,2,3</coordinates>
+		</Point>
+	</Placemark>
+</Document>
+</kml>

Specs/DataSources/KmlDataSourceSpec.js

@@ -263,6 +263,18 @@ defineSuite([
         });
     });
 
+    it('if load contains <icon> tag with no image included, no image is added', function() {
+        var dataSource = new KmlDataSource(options);
+        return loadBlob('Data/KML/simpleNoIcon.kml').then(function(blob) {
+            return dataSource.load(blob);
+        }).then(function(source) {
+            expect(source.entities);
+            expect(source.entities.values.length).toEqual(1);
+            expect(source.entities._entities._array.length).toEqual(1);
+            expect(!source.entities._entities._array[0]._billboard._image);
+        });
+    });
+
     it('sets DataSource name from Document', function() {
         var kml = '<?xml version="1.0" encoding="UTF-8"?>\
             <Document>\