Fix specular flickering in processModelMaterialsCommon #5773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a model uses the KHR_materials_common extension, sets its technique to "PHONG", but doesn't provide specular or shininess values in its material, default values are 0 are used. This causes something to go wrong in the shader math resulting in a flickery effect. This fix is just smarter about checking if the model really has specular.
This issue has come up on the forum a couple times now:
https://groups.google.com/forum/#!topic/cesium-dev/kR7u5R5wq5k
https://groups.google.com/forum/#!topic/cesium-dev/JtTnEncijn0