-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rtl labels support #5771
Merged
+318
−4
Merged
Rtl labels support #5771
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
60da6aa
support rtl characters (currently, only hebrew) at label to show in c…
hodbauer fc812bc
add example of supporting rtl characters to sandcastle
hodbauer 8762607
add unit tests to check rtl (unfortunately, not working yet)
hodbauer 64fd8d2
RTL labels now work in constructor
YonatanKra e3c601f
Merge remote-tracking branch 'AnalyticalGraphicsInc/master'
YonatanKra db98c03
Merge branch 'master' into rtl-labels-support
YonatanKra 5826c7e
Upadated Changes.md
YonatanKra 775e637
Updated contributors
YonatanKra f09b883
Support for \n in RTL
YonatanKra 70c3ab6
Cache RTL original string
YonatanKra 8d18aa3
Prevent glyphs parser from running for nought
YonatanKra 52dc64f
Documentation examples
YonatanKra 8350668
Updated contributors list
YonatanKra a0f0c1a
* fix descriptions
hodbauer 41cea83
support rtl characters (currently, only hebrew) at label to show in c…
hodbauer 84354e4
add example of supporting rtl characters to sandcastle
hodbauer c22adcf
add unit tests to check rtl (unfortunately, not working yet)
hodbauer f91e96d
Merge branch 'master' into rtl-labels-support
hodbauer 281d4d3
support rtl characters (currently, only hebrew) at label to show in c…
hodbauer c1adde1
add example of supporting rtl characters to sandcastle
hodbauer 6d65918
add unit tests to check rtl (unfortunately, not working yet)
hodbauer 5f304a8
RTL labels now work in constructor
YonatanKra 304e774
Updated contributors
YonatanKra f7dfcaa
Support for \n in RTL
YonatanKra 10b05d2
Cache RTL original string
YonatanKra 8878a7b
Prevent glyphs parser from running for nought
YonatanKra 12fe81d
Documentation examples
YonatanKra 15a3c9c
Updated contributors list
YonatanKra 9ab1704
* fix descriptions
hodbauer 04538ba
rename rtl to rightToLeft
hodbauer eb9e155
Merge remote-tracking branch 'origin/rtl-labels-support' into rtl-lab…
hodbauer 97c5c36
support rtl characters (currently, only hebrew) at label to show in c…
hodbauer 7245d72
add example of supporting rtl characters to sandcastle
hodbauer 4a69abf
add unit tests to check rtl (unfortunately, not working yet)
hodbauer cfb6419
RTL labels now work in constructor
YonatanKra ea5ceeb
Updated contributors
YonatanKra c098454
Support for \n in RTL
YonatanKra d3df024
Cache RTL original string
YonatanKra 7068841
Prevent glyphs parser from running for nought
YonatanKra bdb582e
Documentation examples
YonatanKra 99010f2
Updated contributors list
YonatanKra ab9ac19
* fix descriptions
hodbauer 84e5d95
RTL labels now work in constructor
YonatanKra eec1e4d
rename rtl to rightToLeft
hodbauer b3971a9
add link to PR at CHANGES.md
hodbauer 69a49e8
Merge remote-tracking branch 'origin/rtl-labels-support' into rtl-lab…
hodbauer bcc762c
Merge branch 'master' into rtl-labels-support
hodbauer 7a0c0e3
Merge branch 'master' into rtl-labels-support
hodbauer 3432f03
Merge branch 'master' into rtl-labels-support
hodbauer df1ddea
* add more tests for better code coverage
hodbauer 80b370b
Merge remote-tracking branch 'origin/rtl-labels-support' into rtl-lab…
hodbauer 0020337
Merge branch 'master' into rtl-labels-support
hodbauer abc7b9e
Merge branch 'master' into rtl-labels-support
mramato fac9512
Merge remote-tracking branch 'origin/master' into rtl-labels-support
hodbauer 11b485e
Merge remote-tracking branch 'origin/master' into rtl-labels-support
hodbauer 32c5657
declare textTypes of rightToLeft mechanism as object and not a function
hodbauer 118abe4
manage rightToLeft as a static property of Label
hodbauer e109e98
fix tests by set text property also in the Label constructor, which c…
hodbauer c2aa9cc
Tweaks to right-to-left label handling.
mramato 6bca30d
Tweak Sandcastle
mramato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I'm understanding this code correctly, this regex detects whether the letter is RTL (in this case specifically Hebrew) but otherwise the rest of the code is the same for other languages? So if we update this regex for other known RTL character sets (perhaps thise discussed here and here Is that correct? If so that's awesome and we can easily update this to handle the other languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. it only necessary when writing a RTL language in Cesium.
basically yes, I do not do that, because i cannot read other RTL languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, we can merge this with just Hebrew and then I'll open a second PR with an updated regex to support additional languages.