Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter for KmlDataSource.name #5660

Merged
merged 5 commits into from
Jul 24, 2017
Merged

Conversation

cguldner
Copy link
Contributor

Related to #5656.
This allows the ability to set the name of a KmlDataSource.

CHANGES.md Outdated
@@ -16,6 +16,7 @@ Change Log
* Added ability to show tile urls in the 3D Tiles Inspector. [#5592](https://github.com/AnalyticalGraphicsInc/cesium/pull/5592)
* Added behavior to `Cesium3DTilesInspector` that selects the first tileset hovered over if no tilest is specified. [#5139](https://github.com/AnalyticalGraphicsInc/cesium/issues/5139)
* Added ability to provide a `width` and `height` to `scene.pick`. [#5602](https://github.com/AnalyticalGraphicsInc/cesium/pull/5602)
* Added setter for `KkmlDataSource.name` to specify a name for the datasource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo Kkml

* This will be automatically be set to the KML document name on load.
* @memberof KmlDataSource.prototype
* @type {String}
*/
name : {
get : function() {
return this._name;
},
set : function(value) {
if(this._name !== value) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after if: if(this -> if (this

@hpinkos
Copy link
Contributor

hpinkos commented Jul 20, 2017

Thanks @burn123! I just had those two comments. I'll let @mramato take a look at this when it's ready and merge

@hpinkos hpinkos requested a review from mramato July 20, 2017 18:11
@cguldner
Copy link
Contributor Author

@hpinkos Can you trigger a rebuild? This should be ready

@cguldner cguldner closed this Jul 23, 2017
@cguldner cguldner reopened this Jul 23, 2017
@hpinkos
Copy link
Contributor

hpinkos commented Jul 24, 2017

Thanks @burn123! I just pushed a change to remove an extra line of whitespace, then I'll merge this as soon as CI passes.

@cguldner
Copy link
Contributor Author

@hpinkos I think there is something wrong with the Travis builds, because I keep getting timeout errors

@hpinkos
Copy link
Contributor

hpinkos commented Jul 24, 2017

No problem. We pushed a few changes last week that fixed CI in master, but your branch might not be up to date. I ran the test locally and everything is great. Thanks!

@hpinkos hpinkos merged commit 3a24271 into CesiumGS:master Jul 24, 2017
@cguldner cguldner deleted the kmlname-setter branch July 24, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants