Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no-else-return rule #5481

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Conversation

ottaviohartman
Copy link
Contributor

For #5456. Add no-else-return ESLint rule.

Change all instances of the form:

if (a) {
  return x;
else {
  return y;
}

to:

if (a) {
  return x;
}
return y;

@mramato
Copy link
Contributor

mramato commented Jun 19, 2017

Submitted tweak to move new rule to the shared config, but otherwise this looks great. Thanks @omh1280 !

@mramato mramato merged commit 9aa65cd into CesiumGS:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants