Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable four new ESLint rules #5479

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Conversation

ottaviohartman
Copy link
Contributor

Add some rules that were likely lost during the transition from JSHint to ESLint. #5344

These rules are the only of #5456 which do not require code changes in any way.

@ottaviohartman
Copy link
Contributor Author

@mramato I put these in Cesium's .eslintrc.json. Should they go in the shareable config instead?

@mramato
Copy link
Contributor

mramato commented Jun 19, 2017

Yes, they should go in the shareable config. Also, create a 2.0.0 version in CHANGES.md for the shareable config and and add a line for each new rule. Something like Enabled guard-for-in. where the rule links to esline like you did above. When #5456 is done, we'll publish the new version.

@ottaviohartman
Copy link
Contributor Author

As it turns out, only one of these rules (no-floating-decimal) was not enabled by default.

@mramato
Copy link
Contributor

mramato commented Jun 19, 2017

Thanks.

@mramato mramato merged commit f020d97 into CesiumGS:master Jun 19, 2017
@ottaviohartman ottaviohartman deleted the no_change_rules branch June 19, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants